fix(idempotency): TypeError when calling is_missing_idempotency_key with an int#315
Merged
heitorlessa merged 6 commits intoMar 7, 2021
Conversation
Fix for: TypeError: 'int' object is not iterable
heitorlessa
suggested changes
Mar 7, 2021
Contributor
heitorlessa
left a comment
heitorlessa
left a comment
There was a problem hiding this comment.
Great catch! One minor thing to break that into a multi-line statement as that would've been easier to spot this issue too.
| @staticmethod | ||
| def is_missing_idempotency_key(data) -> bool: | ||
| return data is None or not data or all(x is None for x in data) | ||
| return data is None or not data or (type(data).__name__ in ("tuple", "list") and all(x is None for x in data)) |
Contributor
There was a problem hiding this comment.
Can we break this into a multi-line thing?
It's quite complex now and we might find another bug here in the future I'm sure
Codecov Report
@@ Coverage Diff @@
## develop #315 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 91 91
Lines 3339 3341 +2
Branches 162 163 +1
========================================
+ Hits 3335 3337 +2
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
heitorlessa
suggested changes
Mar 7, 2021
Contributor
heitorlessa
left a comment
heitorlessa
left a comment
There was a problem hiding this comment.
Control flow simplification with two Ifs
heitorlessa
suggested changes
Mar 7, 2021
heitorlessa
approved these changes
Mar 7, 2021
Contributor
Author
|
@heitorlessa funny way of doing it: assert type(None).__name__ == "NoneType" |
Contributor
|
First name I actually see type(obj).__name__ tbh as opposed to instance ;)
…On Sun, 7 Mar 2021 at 09:09, Michael Brewer ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> funny way of doing it:
assert type(None).__name__ == "NoneType"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBEY43RE5PTXNUQ4JC3TCMYB3ANCNFSM4YXRJGBQ>
.
|
heitorlessa
added a commit
that referenced
this pull request
Mar 9, 2021
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(logging): Include exception_name (#320) chore: remove gatsby mention as migrated completed refactor(parameters): Consistently reference env (#319) docs(metrics): remove minimum dimensions docs: Correct code examples (#317) docs(metrics): Correct code examples in markdown (#316) fix(idempotency): TypeError when calling is_missing_idempotency_key with an int (#315) docs(metrics): Corrections to the code examples (#314) fix(idempotency): Correctly handle save_inprogress errors (#313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix for
is_missing_idempotency_keywhich can raise aTypeError: 'int' object is not iterablefor the follow code
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.